gmaps,postgres: fix typo in field name and use idiomatic time.Since#271
Open
Abzaek wants to merge 1 commit into
Open
gmaps,postgres: fix typo in field name and use idiomatic time.Since#271Abzaek wants to merge 1 commit into
Abzaek wants to merge 1 commit into
Conversation
- Rename UsageInResultststs -> UsageInResults in PlaceJob struct (obvious keyboard fumble with extra 'tsts'; the method was already correctly named UseInResults) - Replace time.Now().UTC().Sub(lastSave) with time.Since(lastSave) in resultWriter.Run for consistency with Go idioms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix typo in PlaceJob field name
UsageInResultststs→UsageInResults— the extra "tsts" is an obvious keyboard fumble. The public method was already correctly namedUseInResults(); this fixes the backing field to match.Use idiomatic
time.Sincein resultWriterReplace
time.Now().UTC().Sub(lastSave)withtime.Since(lastSave)— the standard library helper that does the same thing more concisely.Verification
gofmtcleango test ./gmaps/...passes